feat: Provide IPv6 support for internal load balancer

[tomkerkhove]

Signed-off-by: GitHub [email protected]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #697

Special notes for your reviewer:

I'm happy to help further but I'm new to Go. I have tried to check the SDK version but from what I've heard it should be fine.

Release note:

Feat: Provide IPv6 support for internal load balancer

[k8s-ci-robot]

Welcome @tomkerkhove!

It looks like this is your first PR to kubernetes-sigs/cloud-provider-azure 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cloud-provider-azure has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @tomkerkhove. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tomkerkhove]

/assign @feiskyer

[aramase]

/ok-to-test

[nilo19]

@tomkerkhove do you test it by creating an internal ipv6 lb typed service?

[tomkerkhove]

We need to use this with AKS-Engine but have not tested this because I'm new to Go.
Is there guidance on how to test this? I'm happy to do so!

[coveralls]

Coverage decreased (-0.004%) to 79.556% when pulling 2876b91 on tomkerkhove:ilb-private into 61c726d on kubernetes-sigs:master.

[aramase]

Thank you for the PR! I did some validation and there is one additional change required on top of removing this check. I've the changes here: https://github.com/kubernetes-sigs/cloud-provider-azure/compare/master...aramase:ipv6-ilb?expand=1. Please take a look and include those as part of your PR.

1. With the current cloud-controller-manager

➜ k describe svc nginx-ipv6-ilb
Name:                     nginx-ipv6-ilb
Namespace:                default
Labels:                   app=nginx
Annotations:              service.beta.kubernetes.io/azure-load-balancer-internal: true
Selector:                 app=nginx
Type:                     LoadBalancer
IP Family Policy:         SingleStack
IP Families:              IPv6
IP:                       fd00::f488
IPs:                      fd00::f488
Port:                     <unset>  80/TCP
TargetPort:               80/TCP
NodePort:                 <unset>  31468/TCP
Endpoints:                [fc00::6]:80
Session Affinity:         None
External Traffic Policy:  Cluster
Events:
  Type     Reason                  Age              From                Message
  ----     ------                  ----             ----                -------
  Normal   EnsuringLoadBalancer    1s (x2 over 6s)  service-controller  Ensuring load balancer
  Warning  SyncLoadBalancerFailed  1s (x2 over 6s)  service-controller  Error syncing load balancer: failed to ensure load balancer: ensure(default/nginx-ipv6-ilb): lb(ds0716-internal) - internal load balancers does not support IPv6

2. With the changes from my branch

➜ k describe svc nginx-ipv6-ilb
Name:                     nginx-ipv6-ilb
Namespace:                default
Labels:                   app=nginx
Annotations:              service.beta.kubernetes.io/azure-load-balancer-internal: true
Selector:                 app=nginx
Type:                     LoadBalancer
IP Family Policy:         SingleStack
IP Families:              IPv6
IP:                       fd00::b523
IPs:                      fd00::b523
LoadBalancer Ingress:     2001:1234:5678:9abc::6
Port:                     <unset>  80/TCP
TargetPort:               80/TCP
NodePort:                 <unset>  32400/TCP
Endpoints:                [fc00::7]:80
Session Affinity:         None
External Traffic Policy:  Cluster
Events:
  Type    Reason                Age   From                Message
  ----    ------                ----  ----                -------
  Normal  EnsuringLoadBalancer  52m   service-controller  Ensuring load balancer
  Normal  EnsuredLoadBalancer   51m   service-controller  Ensured load balancer

[tomkerkhove]

Certainly, I'll make the changes tomorrow!

[tomkerkhove]

Makes a lot of sense, thanks for suggesting @aramase!

[tomkerkhove]

Did a force push because of invalid commit message - Sorry about that.

[feiskyer]

/retest

[feiskyer]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, tomkerkhove

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [feiskyer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[feiskyer]

I merged this without tests since there're urgent asks for this. @nilo19 let's cherry-pick this to old releases and k/k repo.

[tomkerkhove]

Thank you for merging, let me know if I can help any further!