fix: return error when GetServiceProperties fails in account search #6578
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
approved
andyzhangx
force-pushed
the
return-error-GetServiceProperties-failed
branch
from
c4e9308
to
6cdc891
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, cvvz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/cherrypick release-1.30 |
|
/cherrypick release-1.29 |
|
/cherrypick release-1.28 |
|
@andyzhangx: new pull request created: #6581 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@andyzhangx: new pull request created: #6582 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@andyzhangx: new pull request created: #6583 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix: return error when GetServiceProperties fails in account search
when
GetServicePropertiesfailed in account search, original behavior is return false, thus new account will always be created when throttling error happens, this PR returns error when GetServiceProperties fails in account search, thus account search would fail when throttling error happens which is the expected behavior.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: