Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add getFileServicePropertiesCache to fix throttling issue #6564

Merged

Conversation

andyzhangx
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix: add getFileServicePropertiesCache to fix throttling issue

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix: add getFileServicePropertiesCache to fix throttling issue

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

fix: add getFileServicePropertiesCache to fix throttling issue

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 10, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2024
@lzhecheng
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2024
@k8s-ci-robot k8s-ci-robot merged commit 98c2926 into kubernetes-sigs:master Jul 10, 2024
18 checks passed
@andyzhangx
Copy link
Member Author

/cherrypick release-1.30

@andyzhangx
Copy link
Member Author

/cherrypick release-1.29

@andyzhangx
Copy link
Member Author

/cherrypick release-1.28

@andyzhangx
Copy link
Member Author

/cherrypick release-1.27

@k8s-infra-cherrypick-robot

@andyzhangx: new pull request created: #6566

In response to this:

/cherrypick release-1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@andyzhangx: #6564 failed to apply on top of branch "release-1.28":

Applying: fix: add getFileServicePropertiesCache to fix throttling issue
Using index info to reconstruct a base tree...
M	pkg/provider/azure.go
M	pkg/provider/azure_fakes.go
M	pkg/provider/azure_storageaccount.go
M	pkg/provider/azure_storageaccount_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/provider/azure_storageaccount_test.go
CONFLICT (content): Merge conflict in pkg/provider/azure_storageaccount_test.go
Auto-merging pkg/provider/azure_storageaccount.go
Auto-merging pkg/provider/azure_fakes.go
CONFLICT (content): Merge conflict in pkg/provider/azure_fakes.go
Auto-merging pkg/provider/azure.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: add getFileServicePropertiesCache to fix throttling issue
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@andyzhangx: #6564 failed to apply on top of branch "release-1.27":

Applying: fix: add getFileServicePropertiesCache to fix throttling issue
Using index info to reconstruct a base tree...
M	pkg/provider/azure.go
M	pkg/provider/azure_fakes.go
M	pkg/provider/azure_storageaccount.go
M	pkg/provider/azure_storageaccount_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/provider/azure_storageaccount_test.go
CONFLICT (content): Merge conflict in pkg/provider/azure_storageaccount_test.go
Auto-merging pkg/provider/azure_storageaccount.go
CONFLICT (content): Merge conflict in pkg/provider/azure_storageaccount.go
Auto-merging pkg/provider/azure_fakes.go
CONFLICT (content): Merge conflict in pkg/provider/azure_fakes.go
Auto-merging pkg/provider/azure.go
CONFLICT (content): Merge conflict in pkg/provider/azure.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: add getFileServicePropertiesCache to fix throttling issue
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@andyzhangx: new pull request created: #6567

In response to this:

/cherrypick release-1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants