Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade credentialprovider-api-version to v1 #5277

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

lzhecheng
Copy link
Contributor

@lzhecheng lzhecheng commented Jan 11, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

chore: add cmd change for credentialprovider api-version upgrade

Which issue(s) this PR fixes:

Fixes #5276

Special notes for your reviewer:

Does this PR introduce a user-facing change?

chore: add cmd change for credentialprovider api-version upgrade

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


chore: add cmd change for credentialprovider api-version upgrade

fix goimport lint
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 11, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lzhecheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 11, 2024
@lzhecheng
Copy link
Contributor Author

/test pull-cloud-provider-azure-e2e-capz-1-26

@nilo19
Copy link
Contributor

nilo19 commented Jan 11, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit 1c4c956 into kubernetes-sigs:release-1.26 Jan 11, 2024
13 checks passed
@lzhecheng lzhecheng deleted the cp-3756-1.26 branch January 12, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants