Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.0]Support Azure resource ID as userAssignedIdentityID #1740

Merged
merged 3 commits into from
May 17, 2022
Merged

[release-1.0]Support Azure resource ID as userAssignedIdentityID #1740

merged 3 commits into from
May 17, 2022

Conversation

MartinForReal
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Support ARM resource ID as `userAssignedIdentityID`

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/contains-merge-commits needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 17, 2022
@MartinForReal MartinForReal changed the base branch from master to release-1.0 May 17, 2022 02:08
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 17, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 17, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ArchangelSDY (e980d9a)
  • ✅ login: andyzhangx / name: Andy Zhang (83d5a87)
  • ✅ login: feiskyer / name: Pengfei Ni (76a5693)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 17, 2022
@k8s-ci-robot
Copy link
Contributor

@MartinForReal: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cloud-provider-azure-unit f1fc353059dc1e598fef1dda5c5c2f2375f00f4d link true /test pull-cloud-provider-azure-unit
pull-cloud-provider-azure-e2e-ccm-capz f1fc353059dc1e598fef1dda5c5c2f2375f00f4d link true /test pull-cloud-provider-azure-e2e-ccm-capz
pull-cloud-provider-azure-check f1fc353059dc1e598fef1dda5c5c2f2375f00f4d link true /test pull-cloud-provider-azure-check

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 17, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/contains-merge-commits labels May 17, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MartinForReal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 80.448% when pulling 76a5693 on cherrypick-1290 into d5a18d3 on release-1.0.

@jwtty
Copy link
Member

jwtty commented May 17, 2022

related: #1290

feiskyer
feiskyer reviewed May 17, 2022
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2022
@lzhecheng
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 1a09aca into release-1.0 May 17, 2022
@MartinForReal MartinForReal deleted the cherrypick-1290 branch June 2, 2022 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@lzhecheng lzhecheng Awaiting requested review from lzhecheng

Assignees

@feiskyer feiskyer

@lzhecheng lzhecheng

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@MartinForReal @k8s-ci-robot @coveralls @jwtty @lzhecheng @feiskyer @ArchangelSDY @andyzhangx