Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.23] Support Azure resource ID as userAssignedIdentityID #1616

Merged
merged 1 commit into from
May 6, 2022
Merged

[release-1.23] Support Azure resource ID as userAssignedIdentityID #1616

merged 1 commit into from
May 6, 2022

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #1290

/assign lzhecheng

Support ARM resource ID as `userAssignedIdentityID`

@ArchangelSDY
Support ARM resource ID as userAssignedIdentityID
dbdfd13 
This makes it a bit more convenient.
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 29, 2022
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Apr 29, 2022
Merged
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 29, 2022
@lzhecheng
Copy link
Contributor

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed do-not-merge/needs-kind labels Apr 29, 2022
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 80.422% when pulling dbdfd13 on k8s-infra-cherrypick-robot:cherry-pick-1290-to-release-1.23 into 4a429dd on kubernetes-sigs:release-1.23.

@lzhecheng
Copy link
Contributor

/test pull-cloud-provider-azure-e2e-ccm-vmss-basic-lb-1-23

@mboersma
Copy link
Contributor

mboersma commented May 3, 2022

/retest

1 similar comment
@lzhecheng
Copy link
Contributor

/retest

@MartinForReal
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2022
@MartinForReal
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, MartinForReal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit d65294a into kubernetes-sigs:release-1.23 May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@nilo19 nilo19 Awaiting requested review from nilo19

Assignees

@MartinForReal MartinForReal

@lzhecheng lzhecheng

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@k8s-infra-cherrypick-robot @lzhecheng @coveralls @mboersma @MartinForReal @k8s-ci-robot @ArchangelSDY