Support the status output in table format for other inventory types #602
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
Hi @chunglu-chou. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/M
cmd/status/printers/table/adapter.go
Outdated
| @@ -52,13 +56,16 @@ func (rss *ResourceState) Error() error { | |||
| return rss.err | |||
| } | |||
|
|
|||
| func (ca *CollectorAdapter) LatestStatus() *ResourceState { | |||
| func (ca *CollectorAdapter) LatestStatus(invNameMap map[object.ObjMetadata]string, statusSet map[string]bool) *ResourceState { | |||
There was a problem hiding this comment.
Do we have to provide this as parameters to this function? I don't think these are changed as part of the printing process, so it seems like it could be passed in when we create the CollectorAdapter?
There was a problem hiding this comment.
Yeah that makes sense, they do not need to be passed as parameters. Thanks for pointing it out, I will update this.
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/retest |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chunglu-chou, mortent The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This change is to make the status command work for other inventory types.
Add a new column in the table output format representing the inventory name.