Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kustomize buildMetadata documentation #236

Merged
merged 2 commits into from
Feb 3, 2022

Conversation

natasha41575
Copy link
Contributor

@natasha41575 natasha41575 commented Feb 1, 2022

Docs for the new buildMetadata field, which will be released this afternoon (2/1/22).

Most of the docs and examples are copied from the KEP.

/cc @KnVerey

@k8s-ci-robot k8s-ci-robot requested a review from KnVerey February 1, 2022 20:59
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 1, 2022
@natasha41575
Copy link
Contributor Author

natasha41575 commented Feb 2, 2022

I believe I have addressed all comments! @KnVerey

@KnVerey
Copy link
Contributor

KnVerey commented Feb 3, 2022

/lgtm
/approve

Thanks for taking care of this! If you don't mind, please update the link we included in the release notes about this feature once this content is live.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KnVerey, natasha41575

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [KnVerey,natasha41575]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f1f60da into kubernetes-sigs:master Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants