-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: enable windows unit tests #254
Conversation
Hi @mayankshah1607. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Mayank Shah <[email protected]>
40c1829
to
8dcc490
Compare
could you also enable |
@andyzhangx Sure! Shall I add them in a other PR? Wanted to keep this one small and limited to Windows :) |
yes |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, mayankshah1607 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Mayank Shah [email protected]
What type of PR is this?
/kind test
What this PR does / why we need it:
enable windows unit tests
Which issue(s) this PR fixes:
Fixes #253
Requirements:
Special notes for your reviewer:
Release note: