Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: account list throttling issue in CreateVolume #433

Merged
merged 1 commit into from
Sep 19, 2020

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Sep 18, 2020

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: account list throttling issue in CreateVolume

Which issue(s) this PR fixes:

Fixes #432

Requirements:

Special notes for your reviewer:
After the fix, I found it’s throttled in creating file share on 128th PVCs, we use management API(through SRP) to create file share by default, so it looks like using bring your own storage account feature is the only way to create 1000 PVCs in parallel now. bring your own storage account feature uses account key to create file share, it works well in creating 1000 PVCs in parallel, so in that scenario, let’s ask customer to use bring own storage account key way.

W0919 00:26:51.776624 1 controllerserver.go:207] CreateFileShare(pvc-240a9046-678c-4d9c-a0a2-cfc7774db83a) on account(fuse9490b501ea8244d0849) failed with error(failed to get file share(pvc-240a9046-678c-4d9c-a0a2-cfc7774db83a), err: storage.FileSharesClient#Get: Failure responding to request: StatusCode=429 -- Original Error: autorest/azure: Service returned an error. Status=429 Code="TooManyRequests" Message="The request is being throttled as the limit has been reached for operation type - Read_ObservationWindow_00:05:00. For more information, see - https://aka.ms/srpthrottlinglimits"), waiting for retring

Release note:

fix: account list throttling issue in CreateVolume

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

account list throttling issue in CreateVolume
2 participants