fix: account list throttling issue in CreateVolume #433
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix: account list throttling issue in CreateVolume
Which issue(s) this PR fixes:
Fixes #432
Requirements:
Special notes for your reviewer:
After the fix, I found it’s throttled in creating file share on 128th PVCs, we use management API(through SRP) to create file share by default, so it looks like using bring your own storage account feature is the only way to create 1000 PVCs in parallel now. bring your own storage account feature uses account key to create file share, it works well in creating 1000 PVCs in parallel, so in that scenario, let’s ask customer to use bring own storage account key way.
W0919 00:26:51.776624 1 controllerserver.go:207] CreateFileShare(pvc-240a9046-678c-4d9c-a0a2-cfc7774db83a) on account(fuse9490b501ea8244d0849) failed with error(failed to get file share(pvc-240a9046-678c-4d9c-a0a2-cfc7774db83a), err: storage.FileSharesClient#Get: Failure responding to request: StatusCode=429 -- Original Error: autorest/azure: Service returned an error. Status=429 Code="TooManyRequests" Message="The request is being throttled as the limit has been reached for operation type - Read_ObservationWindow_00:05:00. For more information, see - https://aka.ms/srpthrottlinglimits"), waiting for retring
Release note: