Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: fix unit tests' file path compatibility and error message assertion across Windows and Linux platforms #421

Merged
merged 1 commit into from
Sep 16, 2020
Merged

tests: fix unit tests' file path compatibility and error message assertion across Windows and Linux platforms #421

merged 1 commit into from
Sep 16, 2020

Conversation

mayankshah1607
Copy link
Contributor

Signed-off-by: Mayank Shah [email protected]

What type of PR is this?
/kind test

What this PR does / why we need it:
fix unit tests' file path compatibility and error message assertion across Windows and Linux platforms

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added kind/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 15, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 15, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @mayankshah1607. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 15, 2020
@mayankshah1607 mayankshah1607 force-pushed the mayank/unit-test-fix branch 3 times, most recently from e64ba7a to dca5a1a Compare September 15, 2020 09:51
@mayankshah1607
fix: unit tests on Windows
39a7242 
Signed-off-by: Mayank Shah <[email protected]>
mayankshah1607
mayankshah1607 commented Sep 15, 2020
View reviewed changes
pkg/azurefile/nodeserver_test.go
Comment on lines +150 to +151
// todo: Not a desired error. This will need a better fix
WindowsError: fmt.Errorf("prepare publish failed for %s with error: could not cast to csi proxy class", targetTest),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're getting this unexpected error in a lot of places while testing on Windows. Will open a follow-up issue to fix this.

Copy link
Member

@andyzhangx andyzhangx Sep 15, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think csi-proxy.exe should run first before running ut
refer to kubernetes-csi/csi-proxy#69 (comment)

@andyzhangx
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 15, 2020
andyzhangx
andyzhangx approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
let's merge this PR first, thanks.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, mayankshah1607

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit f671861 into kubernetes-sigs:master Sep 16, 2020
@mayankshah1607 mayankshah1607 mentioned this pull request Sep 16, 2020
Closed
@mayankshah1607 mayankshah1607 mentioned this pull request Oct 6, 2020
Closed
@mayankshah1607 mayankshah1607 mentioned this pull request Oct 27, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/test lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mayankshah1607 @k8s-ci-robot @andyzhangx