-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: CVE-2024-38428 remove wget to close vuln, reduce image size #2067
fix: CVE-2024-38428 remove wget to close vuln, reduce image size #2067
Conversation
Welcome @sdx-jkataja! |
Hi @sdx-jkataja. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/retest |
/retest |
1 similar comment
/retest |
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
thanks for the fix! I have made a little change to remove --fail
parameter in curl to let it fail directly if there is package download failure.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, sdx-jkataja The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-1.30 |
/cherrypick release-1.29 |
/cherrypick release-1.28 |
@andyzhangx: new pull request created: #2068 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@andyzhangx: new pull request created: #2069 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@andyzhangx: new pull request created: #2070 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Remove wget from image to close CVE-2024-38428. Edit: vulnerable binary is no longer present in intermediate layers.
Build Docker image in stages, resulting in a smaller image with fewer layers (size reduction 35 MB).
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: