Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix missing securityContext on controller pods #2048

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Aug 7, 2024

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
In #1210 security contexts were added, but none was added to the snapshot controller and the CSI controller. Something similar happened in the azuredisk CSI repo, with the same oversight. In the azuredisk repo, the oversight was fixed in kubernetes-sigs/azuredisk-csi-driver#1805 and this PR is the equivalent for the azurefile CSI.

Requirements:

Release note:

Add securityContext to driver controller and snapshot controller Pods.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xrstf
Once this PR has been reviewed and has the lgtm label, please assign andyzhangx for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 7, 2024
@andyzhangx
Copy link
Member

/retest

@andyzhangx
Copy link
Member

/test pull-azurefile-csi-driver-sanity

1 similar comment
@andyzhangx
Copy link
Member

/test pull-azurefile-csi-driver-sanity

@andyzhangx
Copy link
Member

/test pull-azurefile-csi-driver-e2e-capz

@andyzhangx
Copy link
Member

/retest

@k8s-ci-robot
Copy link
Contributor

@xrstf: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azurefile-csi-driver-sanity ca86db2 link true /test pull-azurefile-csi-driver-sanity
pull-azurefile-csi-driver-e2e-capz-windows-2019-hostprocess ca86db2 link true /test pull-azurefile-csi-driver-e2e-capz-windows-2019-hostprocess
pull-azurefile-csi-driver-e2e-capz-windows-2019 ca86db2 link true /test pull-azurefile-csi-driver-e2e-capz-windows-2019
pull-azurefile-csi-driver-e2e-migration ca86db2 link true /test pull-azurefile-csi-driver-e2e-migration
pull-azurefile-csi-driver-e2e-migration-windows ca86db2 link true /test pull-azurefile-csi-driver-e2e-migration-windows
pull-azurefile-csi-driver-e2e-capz-windows-2022-hostprocess ca86db2 link true /test pull-azurefile-csi-driver-e2e-capz-windows-2022-hostprocess

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@xrstf
Copy link
Contributor Author

xrstf commented Aug 8, 2024

Did I accidentally actually break something?

@andyzhangx
Copy link
Member

Did I accidentally actually break something?

@xrstf No, we are in the middle of migrating all GCP based tests to AWS, that would require efforts.

@andyzhangx andyzhangx merged commit 94be6ff into kubernetes-sigs:master Aug 8, 2024
16 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants