-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix missing securityContext on controller pods #2048
chore: fix missing securityContext on controller pods #2048
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: xrstf The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/test pull-azurefile-csi-driver-sanity |
1 similar comment
/test pull-azurefile-csi-driver-sanity |
/test pull-azurefile-csi-driver-e2e-capz |
/retest |
@xrstf: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Did I accidentally actually break something? |
@xrstf No, we are in the middle of migrating all GCP based tests to AWS, that would require efforts. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
In #1210 security contexts were added, but none was added to the snapshot controller and the CSI controller. Something similar happened in the azuredisk CSI repo, with the same oversight. In the azuredisk repo, the oversight was fixed in kubernetes-sigs/azuredisk-csi-driver#1805 and this PR is the equivalent for the azurefile CSI.
Requirements:
Release note: