Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop resize file share when account limit is exceeded #1345

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Aug 7, 2023

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: stop resize file share when account limit is exceeded

W0807 02:36:49.123547       1 azurefile.go:835] ResizeFileShare(pvc-cfc300e0-0045-401f-8f8c-757910acd8b4) on account(xxx) with new size(419) failed with error(failed to update quota on file share(pvc-cfc300e0-0045-401f-8f8c-757910acd8b4), err: storage.FileSharesClient#Update: Failure responding to request: StatusCode=429 -- Original Error: autorest/azure: Service returned an error. Status=429 Code="TooManyRequests" Message="The request is being throttled as the limit has been reached for operation type - Write_ObservationWindow_00:00:01. For more information, see - https://aka.ms/srpthrottlinglimits"), waiting for retrying

W0807 02:36:49.123579       1 utils.go:139] sleep 180 more seconds, waiting for throttling complete

E0807 02:40:56.098924       1 utils.go:81] GRPC error: rpc error: code = Internal desc = expand volume error: failed to update quota on file share(pvc-cfc300e0-0045-401f-8f8c-757910acd8b4), err: storage.FileSharesClient#Update: Failure sending request: StatusCode=409 -- Original Error: autorest/azure: Service returned an error. Status=<nil> Code="TotalSharesProvisionedCapacityExceedsAccountLimit" Message="The total provisioned capacity of the shares cannot exceed the account maximum size limit.\nRequestId:93685d91-701a-0039-16d8-c83a72000000\nTime:2023-08-07T02:40:56.0668135Z"

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

fix: stop resize file share when account limit is exceeded

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 7, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 7, 2023
@andyzhangx
Copy link
Member Author

/retest

@andyzhangx andyzhangx merged commit b1e1302 into master Aug 7, 2023
16 checks passed
@andyzhangx
Copy link
Member Author

/cherrypick release-1.24

@k8s-infra-cherrypick-robot

@andyzhangx: #1345 failed to apply on top of branch "release-1.24":

Applying: fix: stop resize file share when account limit is exceeded
Using index info to reconstruct a base tree...
M	pkg/azurefile/azurefile.go
M	pkg/azurefile/controllerserver.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/azurefile/controllerserver.go
Auto-merging pkg/azurefile/azurefile.go
CONFLICT (content): Merge conflict in pkg/azurefile/azurefile.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: stop resize file share when account limit is exceeded
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andyzhangx
Copy link
Member Author

/cherrypick release-1.28

@k8s-infra-cherrypick-robot

@andyzhangx: new pull request created: #1346

In response to this:

/cherrypick release-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andyzhangx
Copy link
Member Author

/cherrypick release-1.277

@andyzhangx
Copy link
Member Author

/cherrypick release-1.27

@k8s-infra-cherrypick-robot

@andyzhangx: cannot checkout release-1.277: error checking out release-1.277: exit status 1. output: error: pathspec 'release-1.277' did not match any file(s) known to git

In response to this:

/cherrypick release-1.277

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@andyzhangx: #1345 failed to apply on top of branch "release-1.27":

Applying: fix: stop resize file share when account limit is exceeded
Using index info to reconstruct a base tree...
M	pkg/azurefile/azurefile.go
M	pkg/azurefile/controllerserver.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/azurefile/controllerserver.go
Auto-merging pkg/azurefile/azurefile.go
CONFLICT (content): Merge conflict in pkg/azurefile/azurefile.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: stop resize file share when account limit is exceeded
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants