Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add StorageAccountCache to avoid querying storage account frequently #1344

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Aug 5, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix: add StorageAccountCache to avoid querying storage account frequently

when one storage acount is exceeding quota limit(100TB), AddStorageAccountTags and RemoveStorageAccountTag are called frequently, that would lead to querying storage account frequently, thus finally lead to account operation throttling, this PR adds a timed cache to avoid this issue, and since StorageAccountCache is only for managing tags, it's ok that the data could be outdated due to introducing cache.

related to kubernetes-sigs/cloud-provider-azure#4422

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix: add StorageAccountCache to avoid querying storage account frequently

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

fix: add StorageAccountCache to avoid querying storage account frequently

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 5, 2023
@andyzhangx andyzhangx changed the title [WIP] add cache to reduce get account operations [WIP] fix: add cache to reduce get account operations Aug 5, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 5, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2023
@andyzhangx andyzhangx removed the request for review from cvvz August 5, 2023 09:21
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 5, 2023
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 7, 2023
@andyzhangx andyzhangx changed the title [WIP] fix: add cache to reduce get account operations fix: add StorageAccountCache to avoid querying storage account frequently Aug 7, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 7, 2023
@andyzhangx
Copy link
Member Author

/retest

1 similar comment
@andyzhangx
Copy link
Member Author

/retest

@andyzhangx andyzhangx merged commit abdec54 into master Aug 8, 2023
16 checks passed
@andyzhangx
Copy link
Member Author

/cherrypick release-1.28

@k8s-infra-cherrypick-robot

@andyzhangx: #1344 failed to apply on top of branch "release-1.28":

Applying: fix: add cache to reduce get account operations
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
M	vendor/golang.org/x/crypto/ssh/common.go
M	vendor/golang.org/x/sys/unix/mkerrors.sh
A	vendor/golang.org/x/sys/unix/mremap.go
M	vendor/golang.org/x/sys/unix/syscall_linux.go
M	vendor/golang.org/x/sys/unix/zerrors_linux_arm64.go
M	vendor/golang.org/x/sys/unix/zsyscall_linux.go
M	vendor/golang.org/x/sys/unix/ztypes_linux.go
M	vendor/golang.org/x/sys/unix/ztypes_linux_riscv64.go
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Removing vendor/sigs.k8s.io/cloud-provider-azure/pkg/nodemanager/nodemanager.go
Auto-merging vendor/modules.txt
CONFLICT (content): Merge conflict in vendor/modules.txt
Removing vendor/k8s.io/component-helpers/node/util/status.go
Removing vendor/k8s.io/component-helpers/node/util/ips.go
Removing vendor/k8s.io/component-helpers/node/util/hostname.go
Removing vendor/k8s.io/component-helpers/node/util/conditions.go
Removing vendor/k8s.io/component-helpers/node/util/cidr.go
Removing vendor/k8s.io/cloud-provider/node/helpers/taints.go
Removing vendor/k8s.io/cloud-provider/node/helpers/labels.go
Removing vendor/k8s.io/cloud-provider/node/helpers/address.go
Removing vendor/k8s.io/cloud-provider/api/well_known_taints.go
Removing vendor/k8s.io/cloud-provider/api/well_known_annotations.go
Auto-merging vendor/golang.org/x/sys/unix/ztypes_linux_riscv64.go
Auto-merging vendor/golang.org/x/sys/unix/ztypes_linux.go
Auto-merging vendor/golang.org/x/sys/unix/zsyscall_linux.go
Auto-merging vendor/golang.org/x/sys/unix/zerrors_linux_arm64.go
Auto-merging vendor/golang.org/x/sys/unix/syscall_linux.go
CONFLICT (content): Merge conflict in vendor/golang.org/x/sys/unix/syscall_linux.go
CONFLICT (modify/delete): vendor/golang.org/x/sys/unix/mremap.go deleted in HEAD and modified in fix: add cache to reduce get account operations. Version fix: add cache to reduce get account operations of vendor/golang.org/x/sys/unix/mremap.go left in tree.
Auto-merging vendor/golang.org/x/sys/unix/mkerrors.sh
Removing vendor/golang.org/x/oauth2/CONTRIBUTORS
Removing vendor/golang.org/x/oauth2/AUTHORS
Auto-merging vendor/golang.org/x/crypto/ssh/common.go
CONFLICT (content): Merge conflict in vendor/golang.org/x/crypto/ssh/common.go
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: add cache to reduce get account operations
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants