Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: append nosharesock mount option on Linux node by default #1267

Merged
merged 1 commit into from
May 19, 2023

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: append nosharesock mount option on Linux node by default

nosharesock mount option should be the default mount option, it could avoid sharing same file share mount when there are multiple PVs pointing to the same file share.

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

fix: append nosharesock mount option on Linux node by default

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 18, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 18, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 18, 2023

@andyzhangx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azurefile-csi-driver-e2e-migration-windows a540843 link true /test pull-azurefile-csi-driver-e2e-migration-windows

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andyzhangx
Copy link
Member Author

/retest

@andyzhangx andyzhangx merged commit 544b926 into master May 19, 2023
@andyzhangx
Copy link
Member Author

/cherrypick release-1.24

@k8s-infra-cherrypick-robot

@andyzhangx: #1267 failed to apply on top of branch "release-1.24":

Applying: fix: append nosharesock mount option on Linux node by default
Using index info to reconstruct a base tree...
M	pkg/azurefile/azurefile.go
M	pkg/azurefile/azurefile_test.go
M	pkg/azurefile/nodeserver.go
M	pkg/azurefileplugin/main.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/azurefileplugin/main.go
CONFLICT (content): Merge conflict in pkg/azurefileplugin/main.go
Auto-merging pkg/azurefile/nodeserver.go
CONFLICT (content): Merge conflict in pkg/azurefile/nodeserver.go
Auto-merging pkg/azurefile/azurefile_test.go
CONFLICT (content): Merge conflict in pkg/azurefile/azurefile_test.go
Auto-merging pkg/azurefile/azurefile.go
CONFLICT (content): Merge conflict in pkg/azurefile/azurefile.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: append nosharesock mount option on Linux node by default
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andyzhangx
Copy link
Member Author

/cherrypick release-1.27

@k8s-infra-cherrypick-robot

@andyzhangx: new pull request created: #1268

In response to this:

/cherrypick release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andyzhangx
Copy link
Member Author

/cherrypick release-1.26

@k8s-infra-cherrypick-robot

@andyzhangx: #1267 failed to apply on top of branch "release-1.26":

Applying: fix: append nosharesock mount option on Linux node by default
Using index info to reconstruct a base tree...
M	pkg/azurefile/azurefile.go
M	pkg/azurefile/azurefile_test.go
M	pkg/azurefile/nodeserver.go
M	pkg/azurefileplugin/main.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/azurefileplugin/main.go
CONFLICT (content): Merge conflict in pkg/azurefileplugin/main.go
Auto-merging pkg/azurefile/nodeserver.go
CONFLICT (content): Merge conflict in pkg/azurefile/nodeserver.go
Auto-merging pkg/azurefile/azurefile_test.go
CONFLICT (content): Merge conflict in pkg/azurefile/azurefile_test.go
Auto-merging pkg/azurefile/azurefile.go
CONFLICT (content): Merge conflict in pkg/azurefile/azurefile.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: append nosharesock mount option on Linux node by default
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants