Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Add darwin unit test workflow #564

Merged
merged 1 commit into from
Oct 6, 2020
Merged

CI: Add darwin unit test workflow #564

merged 1 commit into from
Oct 6, 2020

Conversation

mayankshah1607
Copy link
Contributor

Signed-off-by: Mayank Shah [email protected]

What type of PR is this?
/kind test

What this PR does / why we need it:
Add MacOS unit test workflow

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:
@andyzhangx This is a duplicate of #555; working on this clean branch to fix any further test failures as seen in the above mentioned PR

Release note:

none

@k8s-ci-robot
Copy link
Contributor

Hi @mayankshah1607. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 5, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 5, 2020
@mayankshah1607 mayankshah1607 changed the title CI: Add MacOS unit test workflow CI: Add darwin unit test workflow Oct 5, 2020
@mayankshah1607 mayankshah1607 force-pushed the mayank/macos-ut branch 3 times, most recently from 7910ec2 to 03d4ef6 Compare October 5, 2020 10:47
@mayankshah1607
Copy link
Contributor Author

mayankshah1607 commented Oct 5, 2020 •
edited
Loading

@andyzhangx It looks like a lot of cases require different error for darwin. Should we introduce a DarwinError field in TestError?
If left empty, it can use the DefaultError.
Some also have util/mount on this platform is not supported error, so maybe we can skip those cases on darwin

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 5, 2020
@mayankshah1607 mayankshah1607 force-pushed the mayank/macos-ut branch 3 times, most recently from aa77a32 to ca5a78d Compare October 5, 2020 11:51
@andyzhangx
Copy link
Member

@andyzhangx It looks like a lot of cases require different error for darwin. Should we introduce a DarwinError field in TestError?
If left empty, it can use the DefaultError.
Some also have util/mount on this platform is not supported error, so maybe we can skip those cases on darwin

do you have the details about specific DarwinError ? I think it should be same as LinuxError in most cases

@mayankshah1607 mayankshah1607 force-pushed the mayank/macos-ut branch 5 times, most recently from abad032 to c738792 Compare October 5, 2020 12:37
mayankshah1607
mayankshah1607 commented Oct 5, 2020
View reviewed changes
pkg/azuredisk/nodeserver_test.go
desc string
req csi.NodeGetVolumeStatsRequest
expectedErr error
skipOnDarwin bool
Copy link
Contributor Author

@mayankshah1607 mayankshah1607 Oct 5, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andyzhangx In many test cases, I have provided an option to skip on darwin as the tests return the following error:
util/mount on this platform is not supported
Tests are also skipped on darwin when the returned error is nil

@andyzhangx
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 5, 2020
andyzhangx
andyzhangx approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, mayankshah1607

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6c3e84d into kubernetes-sigs:master Oct 6, 2020
@mayankshah1607 mayankshah1607 mentioned this pull request Oct 27, 2020
Closed
6 tasks
sozercan pushed a commit to sozercan/azuredisk-csi-driver that referenced this pull request Aug 16, 2021
@andyzhangx
Merge pull request kubernetes-sigs#564 from kubernetes-sigs/fix-nfs-f…
4944cf5 
…stype

fix: incorrect protocol and fsType combination
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/test lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mayankshah1607 @k8s-ci-robot @andyzhangx