-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide more customization options for the service mutator webhook #3653
Provide more customization options for the service mutator webhook #3653
Conversation
Hi @diversario. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
thanks for the contribution. the change lgtm. can you please add the manual testing you've done on the service mutator webhook in the PR description? thanks. |
Updated description. |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: diversario, oliviassss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue
Description of changes
For #3641, the webhook configuration needs to support at least
operations
customization, but being able to exclude certain services by a selector is important for aws/eks-charts#1063.This PR adds a new section for service mutator webhook configuration. Defaults are set to match the existing configuration, so that this change does not unexpectedly enable service mutation behavior from #3641.
I've not updated the README, want to get feedback first.
Checklist
README.md
for modified charts)version
inChart.yaml
for the modified chart(s)Testing
This change was tested with AWS LBC v2.7.2, and also with AWS LBC built from #3641.
For testing, I had no
UPDATE
operation first, then I enabled it in the chart.Tested by creating a Service via
kubectl apply
, updating it viakubectl apply
, and then replacing it viakubectl replace
.kubectl replace
previously would fail with validation error due to attempt to modifyspec.loadBalancerClass
. No longer fails.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.