-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chart): Added additional service monitor functionality #3645
feat(chart): Added additional service monitor functionality #3645
Conversation
4e6906e
to
b96bb7b
Compare
@kishorj @oliviassss could you please take a look at this PR? The failing workflow looks to have been failing for a while and the fix PR (#3600) was closed. |
b96bb7b
to
8dfb191
Compare
8dfb191
to
50e80c6
Compare
/retest |
1 similar comment
/retest |
@kishorj @oliviassss could you please take a look at this PR? |
@@ -29,7 +25,19 @@ spec: | |||
endpoints: | |||
- port: metrics-server | |||
path: /metrics | |||
{{- with .Values.serviceMonitor.interval }} | |||
scheme: http |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just for my understanding, why we specify http
explicitly here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always set the scheme
so it's very clear what the intent is even for someone who's starting at the ServiceMonitor
and working up through the other resources. From an implementation point of view this is something where even though the default is correct we 100% care about the value, so we should explicitly set it.
/retest |
Signed-off-by: Steve Hipwell <[email protected]>
50e80c6
to
32f83a0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3645 +/- ##
=======================================
Coverage 55.40% 55.40%
=======================================
Files 151 151
Lines 9144 9144
=======================================
Hits 5066 5066
Misses 3736 3736
Partials 342 342 ☔ View full report in Codecov by Sentry. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oliviassss, stevehipwell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@oliviassss it looks like the dependency review job is currently failing across the board (also this PR isn't making any changes to the deps), are you planning on manually merging? |
Issue
This PR will allow manual remediation of #2897.
Description
This PR adds the ability to set the Helm chart
ServiceMonitor
endpoint values forscrapeTimeout
,relabelings
&metricRelabelings
. It also fixes thejobLabel
functionality (it should be a label name and not a value) and refactors theServiceMonitor
template for easier readability.Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯