-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webhook server use TLS 1.2 as minimum version #2394
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishorj, M00nF1sh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## main #2394 +/- ##
==========================================
- Coverage 54.03% 54.02% -0.01%
==========================================
Files 138 138
Lines 7841 7842 +1
==========================================
Hits 4237 4237
- Misses 3287 3288 +1
Partials 317 317
Continue to review full report at Codecov.
|
Issue
Fixes #2368
Description
Use TLS 1.2 as the min version for the webhook server.
Tests
Verified the webhook server refuses to negotiate TLS protocols older than 1.2.
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯