-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deps #396
Fix deps #396
Conversation
Welcome @frioux! |
FYI I don't intend to rebase this again unless a human asks me to. Seems like it's just being ignored. |
If you want to update this PR to not remove all the vendored deps, I am willing to merge it. Fewer dependencies is a good thing and I don't think we need a separate package for a version command. |
ok, I'll do that soon 👍
…On Thu, Nov 18, 2021, 10:56 PM Nicholas Turner ***@***.***> wrote:
If you want to update this PR to not remove all the vendored deps, I am
willing to merge it. Fewer dependencies is a good thing and I don't think
we need a separate package for a version command.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#396 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAB7Y77O7QZRMSG2WEQHGDUMXYKFANCNFSM5EFFWJCQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Remove the use of go.hein.dev/go-version since it causes some of the issues.
@nckturner done! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frioux, nckturner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This program ends up depending on go.hein.dev/go-version, which depends on a really old version of cobra. I removed that package and reimplemented it's functionality to allow upgrading deps. At the same time I removed all the vendored stuff, but I'd be willing to not do that part, it was just the easiest way for me to get this to work.
As a side note: I also submitted a PR to go.hein.dev/go-version that would fix this once merged and this package updates to that version.
Fixes #383