-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: add user/role subcommands #381
Conversation
gyuho
commented
Jun 13, 2021
•
edited
Loading
edited
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
cmd/aws-iam-authenticator/add.go
Outdated
|
||
var addCmd = &cobra.Command{ | ||
Use: "add", | ||
Short: "add IAM entity to an existing aws auth configmap", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we be more explicit in the description that makes it clear this is currently only supported for the configmap backend. i.e. "Note: this does not currently support the CRD and file backends." or something.
Signed-off-by: Gyuho Lee <[email protected]>
@wongma7 had the idea that this would benefit from a dry-run mode, which I think is a great idea, but we can add it in a follow-on PR to get this merged, since its been sitting around for a while (and that way someone else can take it up as well if you don't have time). /lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gyuho, nckturner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |