Indentation and unit test improvements #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
bhks
force-pushed
the
testimprove
branch
2 times, most recently
from
26d3f31 to
04ba25b
Compare
micahhausler
reviewed
Mar 8, 2020
pkg/httputil/client_test.go
Outdated
| if expectedTook > 0 && took < expectedTook { | ||
| t.Fatalf("with rate limit, requests expected took %v, got %v", expectedTook, took) | ||
| if expectedDuration > 0 && observedDuration > expectedDuration { | ||
| t.Fatalf("with rate limit, requests expected took %v, got %v", expectedDuration, observedDuration) |
There was a problem hiding this comment.
Can you also change the "expected took" text here?
micahhausler
approved these changes
Mar 9, 2020
k8s-ci-robot
added
ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bhagwat070919, micahhausler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit test written for client.go has some flaw so improved the test