Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to use regional sts endpoint & imdsV2 #283

Merged
merged 1 commit into from
Jan 7, 2020

Conversation

M00nF1sh
Copy link
Contributor

@M00nF1sh M00nF1sh commented Dec 20, 2019

  1. use regional STS endpoint when "--region" is specified.
    • when "--region ${AWS_REGION}" flag is explicitly specified, regional STS endpoint will be used.
    • when other AWS_SDK aware region config is specified(e.g. AWS_REGION or AWS_DEFAULT_REGION environment variable, region config in ~/.aws/config), the default logic of using global STS endpoint still applies. This is to maintain backwards-compatible for KOPS users that might have disabled regional STS endpoint. However, this is likely to be changed to use regional STS endpoints as well after a few versions.
  2. upgrade AWS SDK to newest version(v1.26.7) which uses IMDSV2 by default.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 20, 2019
Copy link

@mogren mogren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

pkg/token/token.go Outdated Show resolved Hide resolved
Copy link
Member

@micahhausler micahhausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh, micahhausler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0ee7e8b into kubernetes-sigs:master Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants