Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding session name parameter to TokenGenerator #272

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Adding session name parameter to TokenGenerator #272

merged 1 commit into from
Oct 25, 2019

Conversation

SaranBalaji90
Copy link
Contributor

Adding sessionName parameter to authenticator client. Clients can set different session name when using roles to authenticate to API Server.

Changes include,
cmd/../token.go ->
i) Adding new parameter to read the session name.
ii) Added validation to say either forwardSessionName or sessionName can be used when using role but not both.

pkg/.../token.go ->
i) Added SessionName to GetTokenOptions struct
ii) Setting session name when creating session object through role.

cr https://code.amazon.com/reviews/CR-14787523

@k8s-ci-robot
Copy link
Contributor

Welcome @SaranBalaji90!

It looks like this is your first PR to kubernetes-sigs/aws-iam-authenticator 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-iam-authenticator has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 25, 2019
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 25, 2019
@SaranBalaji90 SaranBalaji90 changed the title Adding session name paramter to support custom Adding session name parameter to support custom Oct 25, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 25, 2019
@SaranBalaji90 SaranBalaji90 changed the title Adding session name parameter to support custom Adding session name parameter to TokenGenerator Oct 25, 2019
@nckturner nckturner requested a review from wongma7 October 25, 2019 05:55
nckturner
nckturner reviewed Oct 25, 2019
View reviewed changes
pkg/token/token.go
@@ -279,6 +280,10 @@ func (g generator) GetWithOptions(options *GetTokenOptions) (Token, error) {
})
}

} else if options.SessionName != "" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: remove the empty line above.

micahhausler
micahhausler requested changes Oct 25, 2019
View reviewed changes
Copy link
Member

@micahhausler micahhausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also include an update in the README with your new flag?

Also, can you include a test in /pkg/token/token_test.go?

ofiliz
ofiliz approved these changes Oct 25, 2019
View reviewed changes
cmd/aws-iam-authenticator/token.go
cache := viper.GetBool("cache")

if clusterID == "" {
fmt.Fprintf(os.Stderr, "Error: cluster ID not specified\n")
cmd.Usage()
os.Exit(1)
}
if forwardSessionName && sessionName != "" {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave one blank line between the if blocks. Also please fix the indentation for cmd.Usage and os.Exit calls.

micahhausler
micahhausler approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@micahhausler micahhausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: micahhausler, SaranBalaji90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit 4d41a24 into kubernetes-sigs:master Oct 25, 2019
joanayma pushed a commit to joanayma/aws-iam-authenticator that referenced this pull request Aug 11, 2021
@antonbabenko
Merge pull request kubernetes-sigs#272 from syst0m/master
6005cec 
Added output for generated kubeconfig filename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nckturner nckturner nckturner left review comments

@ofiliz ofiliz ofiliz approved these changes

@micahhausler micahhausler micahhausler approved these changes

@christopherhein christopherhein Awaiting requested review from christopherhein

@wongma7 wongma7 Awaiting requested review from wongma7

Assignees

@micahhausler micahhausler

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SaranBalaji90 @k8s-ci-robot @micahhausler @nckturner @ofiliz