Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Global Different Region STS Endpoints #173

Merged
merged 3 commits into from
Jan 11, 2019
Merged

Support Global Different Region STS Endpoints #173

merged 3 commits into from
Jan 11, 2019

Conversation

sunfuze
Copy link
Contributor

@sunfuze sunfuze commented Nov 8, 2018

  • using regexp to test if host is valid

sts endpoints of different regions

@sunfuze
Support Global Different Region STS Endpoints
6b9d3ee 
* using regexp to test if host is valid
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 8, 2018
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 8, 2018
@sunfuze
Copy link
Contributor Author

sunfuze commented Nov 8, 2018

/assign @mattmoyer

@sunfuze sunfuze mentioned this pull request Nov 8, 2018
Closed
@andromedarabbit
Copy link

Any further news ?

@nckturner
Copy link
Contributor

/assign

@nckturner
Copy link
Contributor

nckturner commented Jan 4, 2019 •
edited
Loading

The regex looks good to me, but I'd like to see some tests checking more of the valid cases.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 9, 2019
@sunfuze
Copy link
Contributor Author

sunfuze commented Jan 9, 2019

The regex looks good to me, but I'd like to see some tests checking more of the valid cases.

I added all region endpoints verify test.

@nckturner
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2019
@nckturner
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nckturner, sunfuze

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit 390d908 into kubernetes-sigs:master Jan 11, 2019
@nckturner nckturner mentioned this pull request Nov 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nckturner nckturner nckturner approved these changes

@mattlandis mattlandis Awaiting requested review from mattlandis

@mattmoyer mattmoyer Awaiting requested review from mattmoyer

Assignees

@nckturner nckturner

@mattmoyer mattmoyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sunfuze @andromedarabbit @nckturner @k8s-ci-robot @mattmoyer