Role assumption names #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 17, 2018 10:39
When using a federated user session in conjunction with
the -r role assumption option, some of the fidelity of that
initial session is lost (ex: caller-specified-name from
https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_variables.html#principaltable)
This will conditionally check, if a new role is asked to be assumed,
if there is already an existing role specified and if so, it will
pass it through to the new session to allow for easier auditing
of users as they traverse more complex IAM role delegation structures.
- Disabled automatic session name mapping for federated users and creating feature flag for explicit "opt-in" of the option. - Explanation and disclaimer added to README - Small linting error to pass `make test`
k8s-ci-robot
added
size/M
micahhausler
requested changes
Aug 17, 2018
pkg/token/token.go
Outdated
| @@ -181,9 +184,29 @@ func (g generator) GetWithRoleForSession(clusterID string, roleARN string, sess | |||
|
|
|||
| // if a roleARN was specified, replace the STS client with one that uses | |||
| // temporary credentials from that role. | |||
| if roleARN != "" { | |||
| if roleARN != "" && g.forwardSessionName { | |||
There was a problem hiding this comment.
You'll need a separate if g.forwardSessionName within the if roleARN != "", this is bypassing role assumption if they aren't forwarding the session name
There was a problem hiding this comment.
Great point! Thanks.
- Fixes a bug where the role would not be appropriately assumed when users that are federated did not specify the new `forward-session-name` argument
micahhausler
requested changes
Aug 17, 2018
pkg/token/token.go
Outdated
| if g.forwardSessionName { | ||
| // Determine if the current session is already a federated identity. If so, | ||
| // we carry through this session name onto the new session to provide better | ||
| // aduiting capabilities |
There was a problem hiding this comment.
Can you change this from 'auditing' to 'debugging'?
pkg/token/token.go
Outdated
| // we carry through this session name onto the new session to provide better | ||
| // aduiting capabilities | ||
| // | ||
| // NOTE: I couldn't figure out a more `direct` way of indicating if the |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jrnt30, mattlandis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
joanayma
pushed a commit
to joanayma/aws-iam-authenticator
that referenced
this pull request
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120
See conversation from #121 for additional context/discussion
When using a federated user session in conjunction with
the -r role assumption option, some of the fidelity of that
initial session is lost (ex: caller-specified-name from
https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_variables.html#principaltable)
This will conditionally check, if a new role is asked to be assumed,
if there is already an existing role specified and if so, it will
pass it through to the new session to allow for easier auditing
of users as they traverse more complex IAM role delegation structures.