Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The repo automation scripts should build statically linked binaries by default #28

Closed
stefancocora opened this issue Dec 8, 2017 · 0 comments
Closed

The repo automation scripts should build statically linked binaries by default #28

stefancocora opened this issue Dec 8, 2017 · 0 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@stefancocora
Copy link
Contributor

The Makefile should build statically linked binaries by default.
At the moment the binaries produced are dynamically linked:

file heptio-authenticator-aws

heptio-authenticator-aws: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, with debug_info, not stripped
stefancocora added a commit to stefancocora/authenticator that referenced this issue Dec 8, 2017
@stefancocora
[feature] Build statically linked elf binaries by default.
777b5ee 
Fixes Github issue kubernetes-sigs#28

Signed-off-by: Stefan Cocora <[email protected]>
stefancocora added a commit to stefancocora/authenticator that referenced this issue Dec 8, 2017
@stefancocora
[feature] Build statically linked elf binaries by default.
dc3f5a0 
Fixes Github issue kubernetes-sigs#28

Signed-off-by: Stefan Cocora <[email protected]>
@stefancocora stefancocora mentioned this issue Dec 8, 2017
Closed
@mattmoyer mattmoyer mentioned this issue Jan 12, 2018
Merged
@mattmoyer mattmoyer added kind/feature Categorizes issue or PR as related to a new feature. kind/bug Categorizes issue or PR as related to a bug. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Jan 12, 2018
mattmoyer pushed a commit to mattmoyer/authenticator that referenced this issue Jan 16, 2018
@stefancocora @mattmoyer
[feature] Build statically linked elf binaries by default.
49f2ba7 
Fixes Github issue kubernetes-sigs#28

Signed-off-by: Stefan Cocora <[email protected]>
mattmoyer pushed a commit to mattmoyer/authenticator that referenced this issue Jan 25, 2018
@stefancocora @mattmoyer
[feature] Build statically linked elf binaries by default.
1d13c73 
Fixes Github issue kubernetes-sigs#28

Signed-off-by: Stefan Cocora <[email protected]>
joanayma pushed a commit to joanayma/aws-iam-authenticator that referenced this issue Aug 11, 2021
@brandonjbjelland
Merge pull request kubernetes-sigs#28 from ilyasotkov/master
a80c6e6 
Allow flexibility of port range allowed of workers_ingress_cluster security group
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefancocora @mattmoyer