Add Affinity to DaemonSet

[karaktaka]

Is this a bug fix or adding new feature?
Feature: Fixes #376

What is this PR about? / Why do we need it?
See Issue #376

What testing is done?
This chart is currently deployed in our cluster and is working fine (besides, it's a very small change)

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: karaktaka / name: Dennis (27eb9b6)

[k8s-ci-robot]

Welcome @karaktaka!

It looks like this is your first PR to kubernetes-sigs/aws-fsx-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-fsx-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @karaktaka. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jacobwolfaws]

Hi @karaktaka, can you rebase the commits into a single commit?

[karaktaka]

Hi @karaktaka, can you rebase the commits into a single commit?

Hey @jacobwolfaws,
certainly. Does this work for you?

[jacobwolfaws]

Sorry for the delayed response,

I think it would make sense to add something like this from the ebs-csi-driver: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/charts/aws-ebs-csi-driver/values.yaml#L336-L344 where this is automatically set for users, but affinity is still configurable. Would like to hear your thoughts on that. Otherwise, this looks good to me.

[torredil]

/ok-to-test

[karaktaka]

Sorry for the delayed response,

I think it would make sense to add something like this from the ebs-csi-driver: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/charts/aws-ebs-csi-driver/values.yaml#L336-L344 where this is automatically set for users, but affinity is still configurable. Would like to hear your thoughts on that. Otherwise, this looks good to me.

I just added the values from the ebs chart as I think they make sense like that.

[jacobwolfaws]

Sorry for the delayed response,
I think it would make sense to add something like this from the ebs-csi-driver: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/charts/aws-ebs-csi-driver/values.yaml#L336-L344 where this is automatically set for users, but affinity is still configurable. Would like to hear your thoughts on that. Otherwise, this looks good to me.

I just added the values from the ebs chart as I think they make sense like that.

No worries, sorry I should have been more clear. This restriction doesn't apply to our driver:

          - key: node.kubernetes.io/instance-type
            operator: NotIn
            values:
            - a1.medium
            - a1.large
            - a1.xlarge
            - a1.2xlarge
            - a1.4xlarge

only the fargate default is needed for us
also can you rebase the commits into a single commit? Other than these two things looks good imo. Will look at why the e2e test is failing for you.

---

e2e test failure:

 Error: nodes-us-west-2a.spec.image: Invalid value: "137112412989/amzn2-ami-hvm-2.0.20220218.3-x86_64-gp2": image specified is invalid: "137112412989/amzn2-ami-hvm-2.0.20220218.3-x86_64-gp2" 

I'll put up a fix for this, is unrelated to your PR

[jacobwolfaws]

@karaktaka sorry for taking so long on this, it seems like I don't get notifications when changes are force-pushed 🤔 . One tiny nit 😅 and I've put up a PR for pinning to a new AMI.

[torredil]

/lgtm

[jacobwolfaws]

tested and behavior appears to work as expected.
Thanks @karaktaka for your contribution to the driver!
/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacobwolfaws, karaktaka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jacobwolfaws]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[toneill818]

Can a new release of the helm chart be created with this change?