Several breaking changes to the helm chart

[krmichel]

Is this a bug fix or adding new feature?
Both and includes a breaking change

Fixes #635
Fixes #847
Fixes #964

What is this PR about? / Why do we need it?
Removes deprecated helm values
Removes support for helm v2
Removes installation of the Snapshot controller

[k8s-ci-robot]

Hi @krmichel. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[krmichel]

@wongma7 Here is the PR I talked about with the breaking changes.

[krmichel]

I will need to add some information to the readme about these changes and upgrading from chart version 1.X to 2.X.

[wongma7]

/ok-to-test

[krmichel]

Looks like the tests are failing since the CSI Snapshotter is no longer being installed. I will try taking a look later.

[wongma7]

https://github.com/kubernetes/kops/blob/ceb5031b59f2408b468ac07a6e38a1fab83e8842/docs/addons.md#snapshot-controller

ah, it only gets auto-installed in 1.21 not 1.20... Our tests are creating 1.20 kops clusters. so, still have to set
spec:
snapshotController:
enabled: true
in https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/hack/kops-patch.yaml#L1

alternatively, kops 1.21 just came out a few days ago, so our tests could create 1.21 kops clusters, but that might be out of scope of this PR https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/hack/e2e/run.sh#L51-L55

[wongma7]

FYI I intend to add a helm changelog (copying how efs did it) here : https://github.com/kubernetes-sigs/aws-ebs-csi-driver/pull/958/files#diff-3e7c1a6135a81558fa6110f37850a0aea8e210a2226bd7c35c3f0819e5a74fe1 . I am hoping I can get it merged soon, in which case you may need to rebase

[wongma7]

As for the EKS test failure, that's due to #967, we can ignore it.

[krmichel]

https://github.com/kubernetes/kops/blob/ceb5031b59f2408b468ac07a6e38a1fab83e8842/docs/addons.md#snapshot-controller

ah, it only gets auto-installed in 1.21 not 1.20... Our tests are creating 1.20 kops clusters. so, still have to set
spec:
snapshotController:
enabled: true
in https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/hack/kops-patch.yaml#L1

alternatively, kops 1.21 just came out a few days ago, so our tests could create 1.21 kops clusters, but that might be out of scope of this PR https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/hack/e2e/run.sh#L51-L55

I might be misreading but I think we will need kops 1.21 but can continue with kube 1.20. I am basing that on this representation seeming more clear to me. I will try it when I get a chance

[wongma7]

You are right, I misunderstood relationship between kops version and k8s version.

I just tried kops 1.20.x to create a 1.20.x k8s version and it ignored snapshotController.

Let me try kops 1.21.x to create a 1.20.x: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/hack/e2e/run.sh#L55

[wongma7]

/test pull-aws-ebs-csi-driver-external-test-eks

[krmichel]

/retest

[wongma7]

/lgtm

thanks very much.

/hold

last chance for folk to mention any 2.0 changes they would like to see...

[wongma7]

/lgtm
/hold cancel

thank you!!!

[wongma7]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krmichel, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wongma7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment