-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable uuid checks on XFS #913
Conversation
b072ee5
to
6149063
Compare
When tested without the second commit (the actual fix in the CSI driver), I can see the newly added test correctly fails when mounting volume + its snapshot on the same node:
There is no system journal, still I think it failed to mount due to uuid conflict. With |
b072ee5
to
6f4c98c
Compare
@jsafrane Hello, this ticket is critical for our team. Do you have any ETA for this PR? Sorry, to disturb you, but I need it to schedule my future work. |
6f4c98c
to
1ea2f79
Compare
Since the e2e test has been merged to Kubernetes (kubernetes/kubernetes#102538), I reworked this PR to update only the driver and add @wongma7 @AndyXiangLi PTAL. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Why not just change the UUID on the restored device? |
Is this a bug fix or adding new feature?
Bugfix
What is this PR about? / Why do we need it?
By default, XFS does not allow mounting two devices that have the same UUID of the XFS filesystem. As result, it's not possible to mount a volume + its restored snapshot.
Therefore disable UUID check in XFS using a mount option.
What testing is done?
Tested with kubernetes/kubernetes#102538