Update santiy test to use ginkgo. #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This have several benefits that: 1. Using consistent testing framework as e2e test 2. Able to define multiple test configurations per: https://github.com/kubernetes-csi/csi-test/tree/master/pkg/sanity 3. Test results will be print to stdout as test runs as opposes to stuck for a while and dump all results at once in the old way
|
/assign @bertinatto |
|
/lgtm |
|
Do we have bots running here? Merging manually. |
Closed
|
@leakingtapan - this will take effect when we move to kubernetes-sigs - I should send the email tomorrow. Closing on Fossabadge issue on licensing. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9
This have several benefits that:
https://github.com/kubernetes-csi/csi-test/tree/master/pkg/sanity
for a while and dump all results at once in the old way
Tested using
make test-sanityand tests are passing.