Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update chart version instead of appVersion #725

Closed
wants to merge 1 commit into from

Conversation

gazal-k
Copy link
Contributor

@gazal-k gazal-k commented Feb 5, 2021

Is this a bug fix or adding new feature?
bug fix

What is this PR about? / Why do we need it?
amending issue introduced by #697

What testing is done?

@k8s-ci-robot
Copy link
Contributor

Hi @gazal-k. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gazal-k
To complete the pull request process, please assign ddebroy after the PR has been reviewed.
You can assign the PR to them by writing /assign @ddebroy in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 5, 2021
@gazal-k
Copy link
Contributor Author

gazal-k commented Feb 5, 2021

@ayberk pls help with this

@gazal-k
Copy link
Contributor Author

gazal-k commented Feb 5, 2021

Nevermind, saw #724

@gazal-k gazal-k closed this Feb 5, 2021
@gazal-k gazal-k deleted the storage-class branch February 5, 2021 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants