Fix stray argument in cloudbuild.yaml #661
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature? fix
What is this PR about? / Why do we need it? this explains the
error.
I still intend to move to a model where the cloudbuild calls a script similar to https://github.com/kubernetes-csi/csi-release-tools/blob/master/prow.sh#L1243 https://github.com/kubernetes-csi/csi-release-tools/blob/master/build.make#L132 (ty to person who pointed me to these : ) ) , it will be easier to maintain than wrestling with cloudbuild syntax, and anyway the github workflow could call the same script so we don't have to maintain two copies of the same code. This is just a nobrainer quickfix.
What testing is done?