-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wait for attachment state after attach/detach #58
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 55
💛 - Coveralls |
Makefile
Outdated
@@ -30,7 +30,7 @@ test-sanity: | |||
|
|||
.PHONY: test-e2e | |||
test-e2e: | |||
go test -v ./tests/e2e/... | |||
ginkgo -v ./tests/e2e/... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im wondering why need to replace go test
with ginkgo
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to enable Ginkgo's verbosity and I also need to run the test with admin privileges due to the mount
command. For some reason, executing go test -ginkgo.v
with sudo
didn't work for me (I think it's related to go modules
), so I called ginkgo
directly.
In any case, I improved these bits by compiling the test and then calling it with sudo
.
/lgtm |
Also, upsdate e2e test.
Fixes #38.
/kind feature
/assign @leakingtapan