Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for attachment state after attach/detach #58

Merged
merged 2 commits into from
Oct 15, 2018

Conversation

bertinatto
Copy link
Member

Also, upsdate e2e test.

Fixes #38.

/kind feature
/assign @leakingtapan

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 12, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 12, 2018
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 12, 2018
@coveralls
Copy link

coveralls commented Oct 12, 2018

Pull Request Test Coverage Report for Build 55

  • 32 of 42 (76.19%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.1%) to 49.378%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cloud/cloud.go 32 42 76.19%
Totals Coverage Status
Change from base Build 53: 1.1%
Covered Lines: 516
Relevant Lines: 1045

💛 - Coveralls

Makefile Outdated
@@ -30,7 +30,7 @@ test-sanity:

.PHONY: test-e2e
test-e2e:
go test -v ./tests/e2e/...
ginkgo -v ./tests/e2e/...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im wondering why need to replace go test with ginkgo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to enable Ginkgo's verbosity and I also need to run the test with admin privileges due to the mount command. For some reason, executing go test -ginkgo.v with sudo didn't work for me (I think it's related to go modules), so I called ginkgo directly.

In any case, I improved these bits by compiling the test and then calling it with sudo.

@leakingtapan
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2018
@k8s-ci-robot k8s-ci-robot merged commit 290b6d0 into kubernetes-sigs:master Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants