Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add arm support #527

Merged
merged 2 commits into from
Aug 27, 2020
Merged

Add arm support #527

merged 2 commits into from
Aug 27, 2020

Conversation

leakingtapan
Copy link
Contributor

@leakingtapan leakingtapan commented Jun 25, 2020 •
edited
Loading

Is this a bug fix or adding new feature?
Fixes: #521

What is this PR about? / Why do we need it?
Add arm support

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 25, 2020
@leakingtapan leakingtapan added this to the 0.6 milestone Jun 25, 2020
@k8s-ci-robot k8s-ci-robot requested review from gnufied and jsafrane June 25, 2020 06:08
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 25, 2020
@coveralls
Copy link

coveralls commented Jun 25, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1128

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.577%
Totals Coverage Status
Change from base Build 1127: 0.0%
Covered Lines: 1430
Relevant Lines: 1797
💛 - Coveralls

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leakingtapan
Copy link
Contributor Author

/retest

@leakingtapan
Copy link
Contributor Author

/hold
blocked by: kubernetes-csi/external-provisioner#381

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2020
@leakingtapan leakingtapan removed this from the 0.6 milestone Jul 5, 2020
@AWSNB
Copy link

AWSNB commented Aug 17, 2020

/hold
blocked by: kubernetes-csi/external-provisioner#381

@leakingtapan can we unblock as ^^ has been closed ?

would this get lgtm so it could get merged ?

@leakingtapan
Copy link
Contributor Author

The blocking issue is there is no corresponding arm images for side car containers published on quay.io AFAIK. I can merge this PR if this work for u. @AWSNB

@AWSNB
Copy link

AWSNB commented Aug 18, 2020

The blocking issue is there is no corresponding arm images for side car containers published on quay.io AFAIK. I can merge this PR if this work for u. @AWSNB

i may be wrong, but the july 16 update covered that : kubernetes-csi/external-attacher@f5a4203

@msau42
Copy link
Contributor

msau42 commented Aug 21, 2020

The upcoming releases for csi sidecars (~ end of the month) will also publish multi-arch images

@jqmichael
Copy link

Just curious. Did anyone actually test things still work with the ARM driver?

@leakingtapan
Copy link
Contributor Author

will it be on quay or gcr only ? @msau42

@msau42
Copy link
Contributor

msau42 commented Aug 24, 2020

The csi project has not tested any of the non-x86 images. They will be published on k8s.gcr.io/sig-storage only. quay.io/k8scsi is no longer going to get new images.

@leakingtapan leakingtapan merged commit b0079ef into kubernetes-sigs:master Aug 27, 2020
@leakingtapan
Copy link
Contributor Author

Merging. Will create a separate issue to track how to enable side car arm images

@scottmalkie scottmalkie mentioned this pull request Sep 15, 2020
Closed
This was referenced Oct 29, 2020
Closed
Closed
@gkrizek gkrizek mentioned this pull request Nov 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied Awaiting requested review from gnufied

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please provide an official aarch64 image for use on m6g, a1
6 participants
@leakingtapan @coveralls @k8s-ci-robot @AWSNB @msau42 @jqmichael