Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make secret optional #247

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Make secret optional #247

merged 1 commit into from
Mar 21, 2019

Conversation

leakingtapan
Copy link
Contributor

Is this a bug fix or adding new feature?
/hold

Fixes: #246

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 20, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 540

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 66.689%
Totals Coverage Status
Change from base Build 538: 0.0%
Covered Lines: 997
Relevant Lines: 1495
💛 - Coveralls

@leakingtapan
Copy link
Contributor Author

retest

@leakingtapan
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2019
@leakingtapan
Copy link
Contributor Author

/retest

@leakingtapan leakingtapan merged commit 52e39e5 into kubernetes-sigs:master Mar 21, 2019
@leakingtapan leakingtapan deleted the opt-secrect branch March 21, 2019 22:21
dobsonj pushed a commit to dobsonj/aws-ebs-csi-driver that referenced this pull request Dec 13, 2023
@openshift-merge-bot
Merge pull request kubernetes-sigs#247 from openshift-bot/art-consist…
c545bfa 
…ency-openshift-4.16-ose-aws-ebs-csi-driver

OCPBUGS-25126: Updating ose-aws-ebs-csi-driver-container image to be consistent with ART
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddebroy ddebroy Awaiting requested review from ddebroy

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removes driver manifest's dependency on secret
3 participants
@leakingtapan @k8s-ci-robot @coveralls