Implement device path discovery for NVMe support #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leakingtapan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/M
|
/cc @dkoshkin @bertinatto |
Pull Request Test Coverage Report for Build 498
💛 - Coveralls |
dkoshkin
suggested changes
Mar 4, 2019
pkg/driver/node.go
Outdated
|
|
||
| // findDevicePath finds and verifies the path of device | ||
| // if the device is not nvme device, return the path | ||
| // if the device is nvme device, returns the actual device path |
There was a problem hiding this comment.
What does "actual device path" mean vs "the path of device"?
There was a problem hiding this comment.
clarified the docs
pkg/driver/node.go
Outdated
| if err != nil { | ||
| if os.IsNotExist(err) { | ||
| klog.V(5).Infof("nvme path %q not found", p) | ||
| return "", nil |
There was a problem hiding this comment.
Should this return an error? The condition of "" isn't checked in the previous functions.
k8s-ci-robot
added
size/L
leakingtapan
force-pushed
the
nvme
branch
2 times, most recently
from
98dad7a
to
f14829f
Compare
|
/test pull-aws-ebs-csi-driver-unit |
/test pull-aws-ebs-csi-driver-e2e-single-az |
|
@dkoshkin if no other concerns, Im going to override the coverage drop and merge the change |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature?
Add support for nvme on Nitro instance
Fixes: #178
What testing is done?
Manually tested following scenario: