-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update list of nitro instances #1573
Conversation
|
Welcome @petderek! |
Hi @petderek. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest |
Thanks! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ConnorJC3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-aws-ebs-csi-driver-external-test |
update list of nitro instances
Is this a bug fix or adding new feature?
bugfix
What is this PR about? / Why do we need it?
Updating the list of nonNitro instances to be in sync with the documentation. There were some types in the list that didn't belong (eg, c7g is a Nitro type), and a few types that needed to be added.
This makes the limit prediction logic a little bit more accurate and helpful for these instance types.
What testing is done?
I ran unit tests -- but it doesn't seem as though I have permission to run any of the other tests. Happy to take suggestions, though.