Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chart Cleanup #1461

Merged
merged 6 commits into from
Jan 10, 2023
Merged

Chart Cleanup #1461

merged 6 commits into from
Jan 10, 2023

Conversation

ConnorJC3
Copy link
Contributor

Add some sensible defaults to the chart (that are already used in the EKS-managed version of the driver), and also add image.containerRegistry parameter to allow prefixing all repositories (we will set this to public.ecr.aws in the upcoming 1.15.0 driver release when we switch the default to the EKS-D sidecars).

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 19, 2022
@k8s-ci-robot k8s-ci-robot requested review from gtxu and rdpsin December 19, 2022 16:39
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 19, 2022
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 19, 2022
@rdpsin
Copy link
Contributor

rdpsin commented Dec 19, 2022

While #1454 is still pending, can you post the results of manually testing/linting the helm chart upgrade?

@ConnorJC3
Copy link
Contributor Author

Current version passes #1454, snippet from end of testing log:

Deleted cluster: "test-cluster-29719.k8s.local"

###
## OVERALL_TEST_PASSED: 0
#
###
## SUCCESS!
#

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 6, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 6, 2023
@torredil
Copy link
Member

torredil commented Jan 6, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2023
@ConnorJC3
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit ce8a68b into kubernetes-sigs:master Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torredil torredil torredil approved these changes

@gtxu gtxu Awaiting requested review from gtxu

@rdpsin rdpsin Awaiting requested review from rdpsin

Assignees

@torredil torredil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ConnorJC3 @rdpsin @torredil @k8s-ci-robot