Bump up sidecar versions #1260
Merged
Bump up sidecar versions #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gtxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/S
gtxu
removed
the
approved
|
please bump up helm chart version |
torredil
reviewed
Jun 3, 2022
| @@ -5,6 +5,7 @@ kind: Deployment | |||
| apiVersion: apps/v1 | |||
| metadata: | |||
| name: ebs-csi-controller | |||
| namespace: default | |||
There was a problem hiding this comment.
What is the reason for explicitly adding this? By default, all resources are created in the default namespace, unless a namespace is specified.
There was a problem hiding this comment.
Yes, this is generated by template namespace: {{ .Release.Namespace }} in helm template. It should be exclude to kustomize profile. WIP address it.
k8s-ci-robot
added
the
lgtm
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature?
What is this PR about? / Why do we need it?
bump up the following sidecars:
external-attacher v3.1.0 -> v3.4.0
external-resizer v1.1.0 -> v1.4.0
external-provisioner v2.2.2 -> v3.1.0
node-driver-registrar v2.3.0 -> v2.5.1
livenessprobe v2.4.0 -> v2.5.0
re-generate kustomize profile
What testing is done?
Unit test and functionality test