Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize CSI Driver name #104

Closed
leakingtapan opened this issue Nov 13, 2018 · 3 comments
Closed

Finalize CSI Driver name #104

leakingtapan opened this issue Nov 13, 2018 · 3 comments
Milestone
alpha

Comments

@leakingtapan
Copy link
Contributor

There is a breaking change going to be introduced by CSI 1.0:

  • Change "reverse domain notation" requirement to "forward domain notation"

We should finalize the EBS CSI Driver name and update README for alpha release.

Proposed names:

  • Driver name: ebs.csi.aws.com
  • Topology Key (in form of prefix/name): topology.ebs.csi.aws.com/zone

Ref: kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#157
@leakingtapan leakingtapan added this to the alpha milestone Nov 13, 2018
@leakingtapan
Copy link
Contributor Author

/cc @d-nishi @bertinatto

leakingtapan pushed a commit to leakingtapan/ebs-csi-driver that referenced this issue Nov 13, 2018
Update driver name and topology key
b7a769f 
Fixes: kubernetes-sigs#104
@leakingtapan leakingtapan mentioned this issue Nov 13, 2018
Merged
leakingtapan pushed a commit to leakingtapan/ebs-csi-driver that referenced this issue Nov 13, 2018
Update driver name and topology key
b68372a 
Fixes: kubernetes-sigs#104
@leakingtapan
Copy link
Contributor Author

/cc @bertinatto @jsafrane

@d-nishi
Copy link
Contributor

d-nishi commented Nov 14, 2018

/lgtm

leakingtapan pushed a commit to leakingtapan/ebs-csi-driver that referenced this issue Nov 14, 2018
Update driver name and topology key
f4dc414 
Fixes: kubernetes-sigs#104
leakingtapan pushed a commit to leakingtapan/ebs-csi-driver that referenced this issue Nov 15, 2018
Update driver name and topology key
b11b08d 
Fixes: kubernetes-sigs#104
@leakingtapan leakingtapan mentioned this issue Feb 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
alpha
Development

No branches or pull requests
2 participants
@leakingtapan @d-nishi