Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix empty path handling #736

Merged
merged 1 commit into from
Nov 16, 2018
Merged

fix empty path handling #736

merged 1 commit into from
Nov 16, 2018

Conversation

M00nF1sh
Copy link
Collaborator

Changes done:

  1. When ingress path is empty, we'll make the rule to be '/*', which aligns the ingress spec of "catch all traffic"
  • This is required since there should be at least one condition for ALB rules.
  • This is required if you modify the rules with specify condition, the condition will not be override. (e.g. remove host/path from ingress spec, the host/path condition won't be modified in ALB rule).

Tests done:

  1. Create ingress without path => ALB rule with "/*" are created.
    • Create ingress with hostname/path => ALB rule with host/condition are created.
    • Remove host/path from ingress => ALB rule modified to have only "/*" path condition

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 16, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 16, 2018
@bigkraig
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2018
@k8s-ci-robot k8s-ci-robot merged commit 8280c49 into kubernetes-sigs:master Nov 16, 2018
@M00nF1sh M00nF1sh deleted the fix-path-pattern branch December 7, 2018 01:48
@sawanoboly
Copy link

@M00nF1sh This change conflicts with Issue below. Please consider about Hostname only entry. 🙏

#573 (comment)

@M00nF1sh
Copy link
Collaborator Author

@M00nF1sh This change conflicts with Issue below. Please consider about Hostname only entry. 🙏

#573 (comment)

@sawanoboly , thanks for sharing the use case 👍
I'll provide a fix today to change the behavior to only maps to "/*" when host condition is not specified.(it's required to have at least one rule)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants