Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AWS client #694

Merged
merged 14 commits into from
Oct 25, 2018
Merged

Refactor AWS client #694

merged 14 commits into from
Oct 25, 2018

Conversation

bigkraig
Copy link

No description provided.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 25, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigkraig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2018
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 25, 2018
@coveralls
Copy link

coveralls commented Oct 25, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-10.7%) to 32.243% when pulling 9fabbd3 on aws-refactor into 98c09b1 on master.

@bigkraig bigkraig changed the title WIP: Refactor AWS client Refactor AWS client Oct 25, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2018
@bigkraig
Copy link
Author

the only place left with the global Cloudsvc is in loadbalancer/main.go now

M00nF1sh
M00nF1sh reviewed Oct 25, 2018
View reviewed changes
internal/ingress/metric/main_test.go
@@ -0,0 +1 @@
package metric
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's this used for?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes coveralls count the package in our overall test coverage

M00nF1sh
M00nF1sh reviewed Oct 25, 2018
View reviewed changes
Copy link
Collaborator

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm :D

@M00nF1sh
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2018
@bigkraig
Copy link
Author

/override coverage/coveralls

@bigkraig
Copy link
Author

/override coverage

@k8s-ci-robot k8s-ci-robot merged commit 31aa413 into master Oct 25, 2018
@bigkraig bigkraig deleted the aws-refactor branch October 25, 2018 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M00nF1sh M00nF1sh M00nF1sh left review comments

Assignees

@M00nF1sh M00nF1sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bigkraig @k8s-ci-robot @coveralls @M00nF1sh