Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Targets controller #654

Merged
merged 6 commits into from
Oct 1, 2018
Merged

Targets controller #654

merged 6 commits into from
Oct 1, 2018

Conversation

bigkraig
Copy link

No description provided.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 30, 2018
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 30, 2018
@bigkraig bigkraig changed the base branch from master to tag-controller September 30, 2018 20:31
@coveralls
Copy link

coveralls commented Sep 30, 2018 •
edited
Loading

Coverage Status

Coverage increased (+2.2%) to 35.536% when pulling 39bcb4e on targets-controller into e1fc19c on tag-controller.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigkraig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bigkraig bigkraig changed the title WIP: Targets controller Targets controller Sep 30, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 30, 2018
@bigkraig bigkraig changed the base branch from tag-controller to master October 1, 2018 16:27
@M00nF1sh
Copy link
Collaborator

M00nF1sh commented Oct 1, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2018
M00nF1sh
M00nF1sh reviewed Oct 1, 2018
View reviewed changes
internal/alb/tg/targets.go
Backend *extensions.IngressBackend
}

// NewTargets returns a new Targets poitner
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pointer typo 😄

@k8s-ci-robot k8s-ci-robot merged commit 354477f into master Oct 1, 2018
bigkraig pushed a commit that referenced this pull request Oct 1, 2018
@k8s-ci-robot
Merge pull request #654 from kubernetes-sigs/targets-controller
f23c3ea 
Targets controller
@bigkraig bigkraig deleted the targets-controller branch October 1, 2018 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M00nF1sh M00nF1sh M00nF1sh left review comments

Assignees

@M00nF1sh M00nF1sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bigkraig @coveralls @k8s-ci-robot @M00nF1sh