-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-0.29] Bump k8s deps to v0.29.2 #569
[release-0.29] Bump k8s deps to v0.29.2 #569
Conversation
Hi @liangyuanpeng. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Please see the two checks failing. Need to /lgtm |
Signed-off-by: Lan Liang <[email protected]>
d636d69
to
6a91316
Compare
Have no change after |
The reason of @jkh52 If you prefer release-0.29 to continue to use 1.20, then I will create a PR for test-infra and add a golang1.20 job to work for release-0.29. |
#565 just merged, let's proceed here.
It does seem better to use 1.21 in release-0.29, to align with k/k. I think it would be reasonable to do in this PR. (What about older branches, like release-0.28? It seems unfortunate if those presubmits will remain similarly affected.) |
Signed-off-by: Lan Liang <[email protected]>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jkh52, liangyuanpeng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This completes kubernetes-sigs#569
Fixes #562