Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.29] Bump k8s deps to v0.29.2 #569

Merged
merged 2 commits into from
Feb 24, 2024

Conversation

liangyuanpeng
Copy link
Contributor

@liangyuanpeng liangyuanpeng commented Feb 21, 2024

  • Bump k8s deps to v0.29.2
  • Update golang version to 1.21

Fixes #562

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 21, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @liangyuanpeng. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 21, 2024
@jkh52
Copy link
Contributor

jkh52 commented Feb 21, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 21, 2024
@jkh52
Copy link
Contributor

jkh52 commented Feb 21, 2024

Please see the two checks failing. Need to go mod tidy and also maybe fix a lint error.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2024
Signed-off-by: Lan Liang <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2024
@liangyuanpeng
Copy link
Contributor Author

Need to go mod tidy

Have no change after go mod tidy and it's working for make test on my local, let's test again with prow.

@liangyuanpeng
Copy link
Contributor Author

liangyuanpeng commented Feb 22, 2024

The reason of pull-apiserver-network-proxy-test failed is prow testing with golang 1.21 and ANP release-0.29 is using 1.20. Kubernetes 1.29 is using 1.21, do we need to update golang version of ANP release-0.29 to 1.21?

@jkh52 If you prefer release-0.29 to continue to use 1.20, then I will create a PR for test-infra and add a golang1.20 job to work for release-0.29.

@jkh52
Copy link
Contributor

jkh52 commented Feb 24, 2024

#565 just merged, let's proceed here.

The reason of pull-apiserver-network-proxy-test failed is prow testing with golang 1.21 and ANP release-0.29 is using 1.20. Kubernetes 1.29 is using 1.21, do we need to update golang version of ANP release-0.29 to 1.21?

@jkh52 If you prefer release-0.29 to continue to use 1.20, then I will create a PR for test-infra and add a golang1.20 job to work for release-0.29.

It does seem better to use 1.21 in release-0.29, to align with k/k. I think it would be reasonable to do in this PR.

(What about older branches, like release-0.28? It seems unfortunate if those presubmits will remain similarly affected.)

@jkh52
Copy link
Contributor

jkh52 commented Feb 24, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkh52, liangyuanpeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3080412 into kubernetes-sigs:release-0.29 Feb 24, 2024
6 checks passed
@liangyuanpeng liangyuanpeng deleted the bump_0.29 branch February 25, 2024 02:40
jkh52 added a commit to jkh52/apiserver-network-proxy that referenced this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants