Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EasyRSA to 3.0.8 #184

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Update EasyRSA to 3.0.8 #184

merged 1 commit into from
Mar 24, 2021

Conversation

MaxRenaud
Copy link
Contributor

Move the archive location from Google Storage to Github Archive
This allows make cert to run on OS with LibreSSL instead of OpenSSL.

See 182 for details.

Tested on macOS Big Sur 11.2.3

@MaxRenaud
Update EasyRSA to 3.0.8
ed989c7 
Move the archive location from Google Storage to Github Archive
This allows ```make cert``` to run on OS with LibreSSL instead of OpenSSL.

Tested on macOS Big Sur 11.2.3
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 23, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @MaxRenaud. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 23, 2021
@MaxRenaud
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@MaxRenaud: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Jefftree
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 23, 2021
@Jefftree
Copy link
Member

make[1]: protoc: Command not found build error doesn't seem related
/retest

@MaxRenaud
Copy link
Contributor Author

/cc jkh

@k8s-ci-robot
Copy link
Contributor

@MaxRenaud: GitHub didn't allow me to request PR reviews from the following users: jkh.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc jkh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MaxRenaud
Copy link
Contributor Author

/assign cheftako

@cheftako
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, MaxRenaud

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2021
@k8s-ci-robot k8s-ci-robot merged commit a04e564 into kubernetes-sigs:master Mar 24, 2021
@MaxRenaud MaxRenaud mentioned this pull request Mar 24, 2021
Closed
@MaxRenaud MaxRenaud deleted the easyrsa branch December 1, 2021 05:03
@MaxRenaud MaxRenaud mentioned this pull request Dec 2, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@Jefftree Jefftree Awaiting requested review from Jefftree

Assignees

@cheftako cheftako

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MaxRenaud @k8s-ci-robot @Jefftree @cheftako