Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

konnectivity-server should make the socket group readable and writeab… #148

Merged
merged 1 commit into from
Oct 12, 2020
Merged

konnectivity-server should make the socket group readable and writeab… #148

merged 1 commit into from
Oct 12, 2020

Conversation

vinayakankugoyal
Copy link
Contributor

…le when it listens on the socket. Most systems have a default umask of 022, meaning when konnectivity-server creates the socket only the user that it is running as will have read-write permissions to the socket. This means that any other process that needs to read-write to the socket needs to be run as the same user as konnectivity-server.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 9, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @vinayakankugoyal!

It looks like this is your first PR to kubernetes-sigs/apiserver-network-proxy 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/apiserver-network-proxy has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @vinayakankugoyal. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from dberkov and Sh4d1 October 9, 2020 16:54
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 9, 2020
@vinayakankugoyal
Copy link
Contributor Author

/cc caesarxuchao

@caesarxuchao
Copy link
Member

/assign @caesarxuchao @cheftako

caesarxuchao
caesarxuchao reviewed Oct 9, 2020
View reviewed changes
Copy link
Member

@caesarxuchao caesarxuchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @vinayakankugoyal.

For future reference, this is the recommended way of setting UDS file descriptor's file permission, according to golang/go#11822

cmd/server/main.go Outdated Show resolved Hide resolved
@caesarxuchao
Copy link
Member

lgtm. Please squash the commits.

@vinayakankugoyal
Copy link
Contributor Author

lgtm. Please squash the commits.

Done. Thanks!

cheftako
cheftako reviewed Oct 9, 2020
View reviewed changes
cmd/server/main.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 9, 2020
@caesarxuchao
Copy link
Member

LGTM.

I'll defer it to Walter to apply the label.

cheftako
cheftako reviewed Oct 10, 2020
View reviewed changes
cmd/server/main.go Outdated Show resolved Hide resolved
@cheftako
Copy link
Contributor

/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 10, 2020
@vinayakankugoyal
konnectivity-server should make the socket group readable and writeab…
42458c2 
…le when it listens on the socket. Most systems have a default umask of 022, meaning when konnectivity-server creates the socket only the user that it is running as will have read-write permissions to the socket. This means that any other process that needs to read-write to the socket needs to be run as the same user as konnectivity-server.

Reset the umask even if listen fails.

Move Umask and getting a uds listener to its own function and protect it
by a lock.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2020
@vinayakankugoyal
Copy link
Contributor Author

/retest

@cheftako
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, vinayakankugoyal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2020
@k8s-ci-robot k8s-ci-robot merged commit 4304536 into kubernetes-sigs:master Oct 12, 2020
@vinayakankugoyal vinayakankugoyal mentioned this pull request Jun 3, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caesarxuchao caesarxuchao caesarxuchao left review comments

@cheftako cheftako cheftako left review comments

@dberkov dberkov Awaiting requested review from dberkov

@Sh4d1 Sh4d1 Awaiting requested review from Sh4d1

Assignees

@cheftako cheftako

@caesarxuchao caesarxuchao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vinayakankugoyal @k8s-ci-robot @caesarxuchao @cheftako