Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to klog v2 [kubernetes-sigs/apiserver-network-proxy] #100

Merged
merged 1 commit into from
Apr 13, 2020
Merged

Switch to klog v2 [kubernetes-sigs/apiserver-network-proxy] #100

merged 1 commit into from
Apr 13, 2020

Conversation

tanjunchen
Copy link
Member

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 9, 2020
@k8s-ci-robot k8s-ci-robot requested review from dberkov and Jefftree April 9, 2020 07:58
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 9, 2020
@tanjunchen tanjunchen changed the title Switch to klog v2 Switch to klog v2 kubernetes-sigs/apiserver-network-proxy Apr 9, 2020
@tanjunchen tanjunchen changed the title Switch to klog v2 kubernetes-sigs/apiserver-network-proxy Switch to klog v2 [kubernetes-sigs/apiserver-network-proxy] Apr 9, 2020
Jefftree
Jefftree reviewed Apr 9, 2020
View reviewed changes
Copy link
Member

@Jefftree Jefftree left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Tested this with both GRPC and http-connect there are no problems.

@tanjunchen: k/k has this repository vendored, I'm assuming the upgrades in k/k all need to be done in one PR?

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 9, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2020
serathius
serathius reviewed Apr 10, 2020
View reviewed changes
go.mod Outdated
google.golang.org/grpc v1.26.0
k8s.io/api v0.17.1
k8s.io/apimachinery v0.17.1
k8s.io/client-go v0.17.1
k8s.io/klog v1.0.0
k8s.io/klog/v2 v2.0.0-rc.1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to v2.0.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2020
@serathius serathius mentioned this pull request Apr 11, 2020
Closed
13 tasks
@dims
Copy link
Member

dims commented Apr 11, 2020

/assign @cheftako @andrewsykim

@dims
Copy link
Member

dims commented Apr 11, 2020

@Jefftree yes the plan is to update all the deps (for k/k) to klog v2 and then bump all those together (see checklist in kubernetes/kubernetes#89961)

@tanjunchen
Copy link
Member Author

kindly ping /cc @Jefftree

@andrewsykim
Copy link
Member

/assign @anfernee

as well :)

@Jefftree
Copy link
Member

/lgtm

/cc @caesarxuchao

as well

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2020
@dims
Copy link
Member

dims commented Apr 13, 2020

@Jefftree please remove hold as well

@Jefftree
Copy link
Member

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 13, 2020
cheftako
cheftako reviewed Apr 13, 2020
View reviewed changes
Copy link
Contributor

@cheftako cheftako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@cheftako
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, tanjunchen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit cce0631 into kubernetes-sigs:master Apr 13, 2020
@tanjunchen tanjunchen deleted the patch-01 branch April 14, 2020 01:12
River-sh pushed a commit to River-sh/apiserver-network-proxy that referenced this pull request Sep 22, 2023
@njucjc
Merge pull request kubernetes-sigs#100 from njucjc/fix-node-ip-forward
e5ad17d 
Fix: forward node ip bugfix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jefftree Jefftree Jefftree left review comments

@serathius serathius serathius left review comments

@cheftako cheftako cheftako left review comments

@dberkov dberkov Awaiting requested review from dberkov

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

Assignees

@anfernee anfernee

@cheftako cheftako

@Jefftree Jefftree

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tanjunchen @dims @andrewsykim @Jefftree @cheftako @k8s-ci-robot @serathius @anfernee