Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider setting proxy server healthz to "not ok" if there is no backend connection for a long time #113

Open
caesarxuchao opened this issue Jun 11, 2020 · 4 comments
Open

Consider setting proxy server healthz to "not ok" if there is no backend connection for a long time #113

caesarxuchao opened this issue Jun 11, 2020 · 4 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@caesarxuchao
Copy link
Member

The /healthz response controls if kubelet restarts a pod. If there is not proxy agent connecting to the proxy server for a long time, then maybe it's a server problem and restarting it might solve the problem. Thus maybe it's worth setting the healthz to "not ok" if there is no backend connection for a long time.

This is all hypothetical so far. If we see evidence in production, then we will come back adding this healthiness condition.

Ref #102 (comment).
@caesarxuchao caesarxuchao added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Jun 11, 2020
@caesarxuchao caesarxuchao mentioned this issue Jun 11, 2020
Merged
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 9, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 9, 2020
@cheftako
Copy link
Contributor

cheftako commented Oct 9, 2020

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 9, 2020
@cheftako
Copy link
Contributor

cheftako commented Oct 9, 2020

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Oct 9, 2020
River-sh pushed a commit to River-sh/apiserver-network-proxy that referenced this issue Sep 22, 2023
@njucjc
Merge pull request kubernetes-sigs#113 from openyurtio/dependabot/go_…
004816d 
…modules/github.com/stretchr/testify-1.8.3

Build(deps): bump github.com/stretchr/testify from 1.8.2 to 1.8.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cheftako @caesarxuchao @k8s-ci-robot @fejta-bot